CONTRIBUTING: remove styleguide info#168
Merged
amstewart merged 1 commit intoni:nilrt/master/hardknottfrom Aug 23, 2022
Merged
Conversation
The styleguide information from the nilrt.git CONTRIBUTING document has been copied into the meta-nilrt.git:docs/styleguide.md doc, in meta-nilrt [#447](ni/meta-nilrt#447). Remove it from the CONTRIBUTING doc. Signed-off-by: Alex Stewart <alex.stewart@ni.com>
Contributor
shruthi-ravi
left a comment
shruthi-ravi
left a comment
There was a problem hiding this comment.
Why can't this documentation live here, common to all the layers?
Contributor
Author
|
Well, it's not common to all layers. Our styleguide only applies to meta-nilrt; devs need to follow the styleguides of the other layers when contributing to them. |
shruthi-ravi
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The styleguide information from the nilrt.git CONTRIBUTING document has
been copied into the meta-nilrt.git:docs/styleguide.md doc, in
meta-nilrt #447.
Remove it from the CONTRIBUTING doc.
Signed-off-by: Alex Stewart alex.stewart@ni.com